Closed
Conversation
Add types for Sealed module components. Replace `static` usage with the `const`. Use `str_starts_with` instead of `substr` function. Add explicit imports for the exception classes. Add PHPDoc to all sealed components. Add new test for coverage `getDecryptionKey` method. Related-Task: INTER-1490
erayaydin
requested review from
Orkuncakilkaya,
TheUnderScorer and
ilfa
as code owners
Contributor
pnpm exec changesetto create a changeset. |
Contributor
|
Following files do not match corresponding templates: To fix this warning, make sure template files are up-to-date, and generate files by running the following command: bash ./scripts/generate.sh |
Contributor
|
🟢 Coverage increased by 35.93% Code Coverage ReportCoverage Report
Files Coverage
|
Member
Author
|
Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add types for
Sealedmodule components. Replacestaticusage with theconst. Usestr_starts_withinstead ofsubstrfunction. Add explicit imports for the exception classes. Add PHPDoc to all sealed components. Add new test for coverage ofgetDecryptionKeymethod.